fix(brush, drag): call start callbacks consistently, support mobile #1286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williaster
commented
Jul 21, 2021
| @@ -256,14 +263,6 @@ export default class BaseBrush extends React.Component<BaseBrushProps, BaseBrush | |||
| extent, | |||
| }; | |||
|
|
|||
| if (onBrushEnd) { | |||
There was a problem hiding this comment.
these shouldn't have been called in the move handler
Size Changes
View raw build statsPrevious (master){
"visx-annotation": {
"esm": 28965,
"lib": 39026
},
"visx-axis": {
"esm": 20970,
"lib": 25370
},
"visx-bounds": {
"esm": 2842,
"lib": 3264
},
"visx-brush": {
"esm": 53861,
"lib": 57769
},
"visx-chord": {
"esm": 3459,
"lib": 4688
},
"visx-clip-path": {
"esm": 4421,
"lib": 5978
},
"visx-curve": {
"esm": 323,
"lib": 1464
},
"visx-demo": {
"esm": 0,
"lib": 0
},
"visx-drag": {
"esm": 6716,
"lib": 8780
},
"visx-event": {
"esm": 3797,
"lib": 5172
},
"visx-geo": {
"esm": 13259,
"lib": 16519
},
"visx-glyph": {
"esm": 14893,
"lib": 19789
},
"visx-gradient": {
"esm": 17800,
"lib": 22517
},
"visx-grid": {
"esm": 18922,
"lib": 22784
},
"visx-group": {
"esm": 1619,
"lib": 2246
},
"visx-heatmap": {
"esm": 7286,
"lib": 8622
},
"visx-hierarchy": {
"esm": 12266,
"lib": 18076
},
"visx-legend": {
"esm": 26999,
"lib": 34033
},
"visx-marker": {
"esm": 8962,
"lib": 11197
},
"visx-mock-data": {
"esm": 326005,
"lib": 329416
},
"visx-network": {
"esm": 4546,
"lib": 6706
},
"visx-pattern": {
"esm": 11779,
"lib": 15910
},
"visx-point": {
"esm": 819,
"lib": 1094
},
"visx-react-spring": {
"esm": 14096,
"lib": 18637
},
"visx-responsive": {
"esm": 21901,
"lib": 26961
},
"visx-scale": {
"esm": 18452,
"lib": 29710
},
"visx-shape": {
"esm": 86057,
"lib": 107037
},
"visx-stats": {
"esm": 13911,
"lib": 15494
},
"visx-text": {
"esm": 8518,
"lib": 10981
},
"visx-threshold": {
"esm": 2911,
"lib": 3820
},
"visx-tooltip": {
"esm": 14147,
"lib": 20413
},
"visx-visx": {
"esm": 970,
"lib": 8243
},
"visx-voronoi": {
"esm": 2286,
"lib": 3005
},
"visx-xychart": {
"esm": 169792,
"lib": 236528
},
"visx-zoom": {
"esm": 16029,
"lib": 17701
}
}Current{
"visx-annotation": {
"esm": 28965,
"lib": 39026
},
"visx-axis": {
"esm": 20970,
"lib": 25370
},
"visx-bounds": {
"esm": 2842,
"lib": 3264
},
"visx-brush": {
"esm": 54984,
"lib": 58922
},
"visx-chord": {
"esm": 3459,
"lib": 4688
},
"visx-clip-path": {
"esm": 4421,
"lib": 5978
},
"visx-curve": {
"esm": 323,
"lib": 1464
},
"visx-demo": {
"esm": 0,
"lib": 0
},
"visx-drag": {
"esm": 6751,
"lib": 8815
},
"visx-event": {
"esm": 3797,
"lib": 5172
},
"visx-geo": {
"esm": 13259,
"lib": 16519
},
"visx-glyph": {
"esm": 14893,
"lib": 19789
},
"visx-gradient": {
"esm": 17800,
"lib": 22517
},
"visx-grid": {
"esm": 18922,
"lib": 22784
},
"visx-group": {
"esm": 1619,
"lib": 2246
},
"visx-heatmap": {
"esm": 7286,
"lib": 8622
},
"visx-hierarchy": {
"esm": 12266,
"lib": 18076
},
"visx-legend": {
"esm": 26999,
"lib": 34033
},
"visx-marker": {
"esm": 8962,
"lib": 11197
},
"visx-mock-data": {
"esm": 326005,
"lib": 329416
},
"visx-network": {
"esm": 4546,
"lib": 6706
},
"visx-pattern": {
"esm": 11779,
"lib": 15910
},
"visx-point": {
"esm": 819,
"lib": 1094
},
"visx-react-spring": {
"esm": 14096,
"lib": 18637
},
"visx-responsive": {
"esm": 21901,
"lib": 26961
},
"visx-scale": {
"esm": 18452,
"lib": 29710
},
"visx-shape": {
"esm": 86057,
"lib": 107037
},
"visx-stats": {
"esm": 13911,
"lib": 15494
},
"visx-text": {
"esm": 8518,
"lib": 10981
},
"visx-threshold": {
"esm": 2911,
"lib": 3820
},
"visx-tooltip": {
"esm": 14147,
"lib": 20413
},
"visx-visx": {
"esm": 970,
"lib": 8243
},
"visx-voronoi": {
"esm": 2286,
"lib": 3005
},
"visx-xychart": {
"esm": 169792,
"lib": 236528
},
"visx-zoom": {
"esm": 16029,
"lib": 17701
}
} |
kristw
approved these changes
Jul 21, 2021
This was referenced Jul 21, 2021
|
🎉 This PR is included in version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Bug Fix
This should fix both
Demo of the start/end callback invocations for move/resize/fresh brush:
@gazcn007 @kristw
cc @JoeVanGundy