You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is the intent here just to make sure that running tests with BUILD_LIBRARY_FOR_DISTRIBUTION doesn't break anything? I would have expected some kind of change in the project file or package spec as well.
To my understanding, if your clients don't intend to build JOSESwift separately you shouldn't enable library evolution (See here, under "When to enable library evolution support"). So if your clients wants to build it separately they should enable it themselves.
On another matter: Clients who pre-compile the library will use the archive command, but the current check runs the tests. Should I add another step that checks with the archive command? Or is it an overkill to add a step just for that?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #266