Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update what-is-a-locale.md #229

Merged
merged 2 commits into from
Sep 25, 2018
Merged

Update what-is-a-locale.md #229

merged 2 commits into from
Sep 25, 2018

Conversation

LaureBrosseau
Copy link
Contributor

I have removed the locale properties, rearranged some text. Added a part "Do I need one locale enabled or more?"

I have removed the locale properties, rearranged some text. Added a part "Do I need one locale enabled or more?"
Copy link
Contributor

@NolwennP NolwennP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do we do with the French translation of this article that already exists? Should we create a ticket to remember to update the translation as well?

@LaureBrosseau
Copy link
Contributor Author

Hi @NolwennP, I created an issue to handle this: #230 :)

Copy link
Contributor

@NolwennP NolwennP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was ready to approve your PR, but I just saw that it's missing related articles. Can you add some? Like the Manage your locales one, the ones on the EE permissions... Thanks!

Added some related articles
@LaureBrosseau LaureBrosseau merged commit 07e57da into master Sep 25, 2018
@LaureBrosseau LaureBrosseau deleted the LaureBro-patch-2 branch September 25, 2018 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants