feat: add oauth support to react native signer #1273
Draft
+461
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
How to use the Graphite Merge QueueAdd the label graphite-merge-queue to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
iykazrji
requested review from
moldy530,
rthomare,
dancoombs,
mokok123,
dphilipson,
linnall,
adamegyed,
howydev,
Zer0dot,
jaypaik and
Blu-J
as code owners
iykazrji
changed the title
moldy530
reviewed
Jan 11, 2025
iykazrji
commented
Jan 14, 2025
Comment on lines
+156
to
+157
| if (await InAppBrowser.isAvailable()) { | ||
| const res = await InAppBrowser.openAuth(providerUrl, redirectUrl); |
There was a problem hiding this comment.
We actually can await the result of the redirect operation and use it to complete the auth instead of calling authenticate(type: "oauthReturn").
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
yarn test)sitefolder, and guidelines for updating/adding docs can be found in the contribution guide)feat!: breaking change)yarn lint:check) and fix any issues? (yarn lint:write)PR-Codex overview
This PR primarily enhances the
rn-signerlibrary by introducing OAuth functionality, improving buffer handling, and adding utility functions for deep linking and URL parameter parsing. It also updates the structure of theRNAlchemySignerclass and adds new screens for authentication.Detailed summary
Bufferpolyfill inbuffer-polyfill.ts.RNAlchemySignerwith OAuth capabilities.OAuthScreenfor OAuth authentication.getDeepLinkandbase64UrlEncodeutilities.RNSignerClientwith OAuth methods and error handling.parseSearchParams.package.jsonto include new dependencies.