Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: upgrade to v4x.x.x #729

Merged
merged 169 commits into from
Aug 28, 2024
Merged

feat!: upgrade to v4x.x.x #729

merged 169 commits into from
Aug 28, 2024

Conversation

moldy530
Copy link
Collaborator

Base branch for all of the v4.x.x changes

Copy link

vercel bot commented Jun 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
aa-sdk-site ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 4:07pm
aa-sdk-ui-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 28, 2024 4:07pm

Comment on lines +5 to +9
export abstract class BaseError extends CoreBaseError {
// This version could be different from the aa-core version so we overwrite this here.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <jsdoc/require-jsdoc> reported by reviewdog 🐶
Missing JSDoc comment.

Comment on lines +4 to +9
export abstract class BaseError extends CoreBaseError {
// This version could be different from the aa-core version so we overwrite this here.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <jsdoc/require-jsdoc> reported by reviewdog 🐶
Missing JSDoc comment.

Comment on lines 8 to 21
export const useSigner = (): AlchemyWebSigner | null => {
const { config } = useAlchemyAccountContext();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <jsdoc/require-jsdoc> reported by reviewdog 🐶
Missing JSDoc comment.

rthomare
rthomare previously approved these changes Jun 17, 2024
@moldy530
Copy link
Collaborator Author

note: gonna hold off on merging this until we have all of the v4.x.x changes in here. Still need to wrap up the docs gen, some breaking method changes, and docs refactoring

dphilipson
dphilipson previously approved these changes Jun 17, 2024
@moldy530 moldy530 dismissed stale reviews from dphilipson and rthomare via 6afff79 June 18, 2024 16:11
* fix(ui-modal): don't render ui modal if no ui config is passed in

* fix: errors thrown about signer state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.