Skip to content
This repository has been archived by the owner on Feb 9, 2022. It is now read-only.

Revert #3464. #3474

Merged
merged 2 commits into from
Feb 10, 2021
Merged

Revert #3464. #3474

merged 2 commits into from
Feb 10, 2021

Conversation

mattstein
Copy link
Contributor

Sorry for the noise—this was a bad idea and made things worse. 🤦‍♂️

@shortcuts
Copy link
Member

Hi,

Could you please give me a detailed example of what should be accomplished?

Thanks

@shortcuts shortcuts merged commit fddc8a1 into algolia:master Feb 10, 2021
@mattstein
Copy link
Contributor Author

Hi @shortcuts, thanks for merging! I noted what I was attempting to solve in this issue:
pixelandtonic/vuepress-theme-craftdocs#22

I’m not sure if it’s more an issue of UI or indexing, and reverting this change doesn’t solve it but gets us back to a preferable form of problem until I can spend more time on it.

@shortcuts
Copy link
Member

Hi!

So, for now having .sidebar-heading.open as a lvl1 selector could help but it will display something like craft\commerce\elements.

Best solution would be to have a special selector around the last part (id, class, etc.)

@mattstein
Copy link
Contributor Author

Thanks for the quick response, @shortcuts!

That .theme-default-content .router-link-exact-active selector worked perfectly as a lvl1 selector in terms of what I intended to index—it’s the VuePress DocSearch UI that became uncomfortably cluttered and harder to read.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants