Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[reflection][fix][msvc]: warning C4127 #865

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[reflection][fix][msvc]: warning C4127 #865

merged 1 commit into from
Dec 23, 2024

Conversation

MiroKaku
Copy link
Contributor

Why

MSVC: Compiler Warning (level 4) C4127, conditional expression is constant.

Example

struct TestReflected
{
    int a;
};
constexpr auto name = ylt::reflection::get_struct_name<TestReflected>();

@CLAassistant
Copy link

CLAassistant commented Dec 21, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@poor-circle
Copy link
Collaborator

LGTM

@qicosmos qicosmos self-requested a review December 23, 2024 08:03
qicosmos
qicosmos approved these changes Dec 23, 2024
View reviewed changes
Copy link
Collaborator

@qicosmos qicosmos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions GitHub Actions
Copy link

for detail, goto summary download Artifacts base-ylt-cov-report(base commit coverage report) and ylt-cov-report(current pull request coverage report)

@qicosmos qicosmos changed the title [fix][reflection][msvc]: warning C4127 [reflection][fix][msvc]: warning C4127 Dec 23, 2024
@qicosmos qicosmos merged commit fac0f5e into alibaba:main Dec 23, 2024
36 checks passed
@MiroKaku MiroKaku deleted the fix/reflection/msvc/C4127 branch December 23, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qicosmos qicosmos qicosmos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@MiroKaku @CLAassistant @poor-circle @qicosmos