Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ui] "About" dialog: Fix some display issues #2640

Merged
merged 4 commits into from
Jan 7, 2025
Merged

Conversation

cbentejac
Copy link
Contributor

Description

This PR removes some code from the "About" dialog that was not working anymore and fixes the following:

  • Display (correctly) the icon to access AliceVision's website;
  • Replace "GitHub"'s icon, which was a 32x32px png image, with an SVG one to prevent resolution issues (like the one reported in HiDPI: github logo in about #2636);
  • Use the same color for all the icons in the dialog.

Prior to this PR, the "About" dialog looked like this:

With it, it now looks as follows:

@cbentejac cbentejac added this to the Meshroom 2024.1.0 milestone Jan 7, 2025
@cbentejac cbentejac self-assigned this Jan 7, 2025
@cbentejac cbentejac linked an issue Jan 7, 2025 that may be closed by this pull request
Copy link

codecov bot commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.93%. Comparing base (f8f549a) to head (728f2ea).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2640   +/-   ##
========================================
  Coverage    69.93%   69.93%           
========================================
  Files          121      121           
  Lines         7088     7088           
========================================
  Hits          4957     4957           
  Misses        2131     2131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fabiencastan fabiencastan merged commit e5b0dbd into develop Jan 7, 2025
5 checks passed
@fabiencastan fabiencastan deleted the fix/aboutDialog branch January 7, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

HiDPI: github logo in about
2 participants