Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 02 13 prototype version 3 updates #138

Merged
merged 14 commits into from
Feb 27, 2024

Conversation

christophercameron-ixd
Copy link
Contributor

PR Checklist

  • Set yourself as the Assignee
  • Tag anyone you would like to review, or @forms-design or @forms-devs
  • Fill in the template below

What

I’ve updated the documentation to cover the differences between the previous version (2) and this version (3). It includes reasons for why we made changes, and quotes if available.
Fixed navigation, typos and missing information.

For more information about what was done, see the trello card.

How to review

  1. Syntactic: Spelling, grammar, etc.
  2. Semantic: Do you agree with the changes?
  3. Is there any information missed, or reasoning for a change you can remember that isn’t covered?
  4. Are we happy for the research document links I have added to be included?

Who can review

Anyone from the team, but have asked for specific review from content and user research.

@christophercameron-ixd christophercameron-ixd added the documentation Improvements or additions to documentation label Feb 20, 2024
Copy link
Contributor

@oliverquinlan oliverquinlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure the links to the user research docs here are the right ones. They both lead to team documentation about how we were going to run the sessions.

The analysis for this was documented in Mural: https://app.mural.co/t/gaap0347/m/gaap0347/1654781687567/0191bfd6e08b968770d46ffb9419b5ef2ef12a91?sender=ae8920e3-ae89-493e-af47-566a135db4be

The playback link might be more user friendly for reference here: https://drive.google.com/file/d/1vwLW90GR0rRnBGtiRKi4BkGe1w7N3_Ez/view?usp=sharing

@oliverquinlan
Copy link
Contributor

@christophercameron-ixd I'm relatively new to reviewing things on Github so sorry if I've not approached this right. I looked at the changes and saw the links I've commented on, however when I look at the branch normally viewing the whole thing the UR sections look fine, well documented and the correct links. Please could you check my comment but I think this is all fine. Ping me when you have and I will approve the request.

@oliverquinlan
Copy link
Contributor

Thanks happy with changing this to reference the UR docs on github so we can keep the links to further documentation in one place.

Copy link
Contributor

@oliverquinlan oliverquinlan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@christophercameron-ixd christophercameron-ixd merged commit ae5617b into main Feb 27, 2024
@christophercameron-ixd christophercameron-ixd deleted the 2024-02-13-prototype-version-3-updates branch February 27, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants