New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: call base contract init function #83

Merged

bb111189 merged 1 commit into m2-dev from audit/3.1

Apr 3, 2024

Contributor

renlulu commented Apr 3, 2024 •

edited by bb111189

Loading

Issue: initialize should call __ServiceManagerBase_init(initialOwner) instead of transferOwnership

ServiceManagerBase exposes an initialization chain. Use the init function to initialize Base for maximum compatibility.

src/ServiceManagerBase.sol (Lines 47-49):

function __ServiceManagerBase_init(address initialOwner) internal virtual onlyInitializing {
    _transferOwnership(initialOwner);
}

function __ServiceManagerBase_init(address initialOwner) internal virtual onlyInitializing {
    _transferOwnership(initialOwner);
}


          refactor: call base contract init function

2daec7d

github-actions bot added the XS label

bb111189 merged commit d006675 into m2-dev

1 check passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

XS