Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Medium icon which is hidden on Docusaurus footer #1154

Closed
wants to merge 1 commit into from
Closed

Fix Medium icon which is hidden on Docusaurus footer #1154

wants to merge 1 commit into from

Conversation

znamazbayeva
Copy link

@znamazbayeva znamazbayeva commented Jul 9, 2022

Description

The medium icon can not be seen because the icon only appeared in library starting from version 4.3.0. Therefore, I have updated the version of the library and added the medium icon.

The icon are similar except the instagram icon which was upgraded I guess.

Fixes #1148

Type of Change:

  • Code

Code/Quality Assurance Only

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials

Code/Quality Assurance Only

  • My changes generate no new warnings

Screen Shot 2022-07-10 at 03 03 39

@znamazbayeva znamazbayeva requested a review from isabelcosta as a code owner July 9, 2022 21:04
@welcome
Copy link

welcome bot commented Jul 9, 2022

Hello there!👋 Welcome to the project!💖
Thank you and congrats 🎉 for opening your first PR on this project.✨
Please ensure your Pull Request meets the Commit Message Style Guide.
We will review it soon! Until then you can check out the README.md for more details on it.

AnitaB.org Open Source is an inclusive community, committed to creating a safe and positive environment 🌸 Please follow our Code Of Conduct.

Feel free to join our community at AnitaB.org Open Source Zulip Community to be kept up to date with our projects discussions and community activities.
Hope you have a great time here :)

@znamazbayeva
Copy link
Author

Hello @isabelcosta! I think there is a problem with the test units as I have understood from #1153. What I can do with it? Can you check my solution?

@znamazbayeva znamazbayeva closed this by deleting the head repository Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix Medium icon which is hidden on Docusaurus footer
1 participant