vmware_first_class_disk_info - Add a module to gather infos about first class disks #1996
Conversation
|
Build failed.
|
|
@ihumster do you know if I need to write tests? |
|
If it possible, of course. |
|
Build failed. ❌ ansible-tox-linters FAILURE in 9m 41s |
|
Build failed. ❌ ansible-tox-linters FAILURE in 10m 41s |
|
Build failed. ❌ ansible-tox-linters FAILURE in 10m 32s |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 37s |
missed the BaseConfigInfo Üroperties
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 58s |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 10m 22s |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 42s |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 45s |
There was a problem hiding this comment.
Thanks for adding tests!
But I think we need validate_certs: false in some places to make the CI happy because we don't have official / trusted certs there.
BTW I think you should remove the changelog fragment. It's not needed, new modules should show up in the changelog automatically ;-)
But you should add the module to community.vmware/meta/runtime.yml.
I didn't find the time to test the module, though :-/
…ain.yml Co-authored-by: Mario Lenz <[email protected]>
…at-m/community.vmware into vmware_first_class_disk_info
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 51s |
|
recheck |
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 10m 29s |
There was a problem hiding this comment.
@Nina2244 I'm trying to understand why the CI fails and it looks like result_create_vcenter isn't registered anywhere. It might be a good thing to have this to troubleshoot the CI, but then 1) you should register the result when creating the FCD and 2) move it upwards so this this would be logged directly after the task that (tries to) create the FCD.
Alternatively, just remove this. We could add it later when we think this necessary.
tests/integration/targets/vmware_first_class_disk_info/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/vmware_first_class_disk_info/tasks/main.yml
Outdated
Show resolved
Hide resolved
tests/integration/targets/vmware_first_class_disk_info/tasks/main.yml
Outdated
Show resolved
Hide resolved
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 10m 13s |
tests/integration/targets/vmware_first_class_disk_info/tasks/main.yml
Outdated
Show resolved
Hide resolved
…ain.yml Co-authored-by: Mario Lenz <[email protected]>
|
Build failed. ✔️ ansible-tox-linters SUCCESS in 9m 56s |
tests/integration/targets/vmware_first_class_disk_info/tasks/main.yml
Outdated
Show resolved
Hide resolved
…ain.yml Co-authored-by: Mario Lenz <[email protected]>
|
Build succeeded. ✔️ ansible-tox-linters SUCCESS in 10m 34s |
mariolenz
added
feature
|
Build succeeded (gate pipeline). ✔️ ansible-tox-linters SUCCESS in 10m 43s |
softwarefactory-project-zuul
bot
merged commit 1ee1822
into
ansible-collections:main
|
@mariolenz I have a question.. do you know if the vsan Lib/module (https://vdc-download.vmware.com/vmwb-repository/dcr-public/b21ba11d-4748-4796-97e2-7000e2543ee1/b4a40704-fbca-4222-902c-2500f5a90f3f/) can also be used? |
|
I'm not sure if I understand the question... as far as I understand, FCDs (or whatever the officially used name is) are independent from VSAN. I've tested the module with FCDs on a VSAN datastore and it worked. I don't know if this helps you or answers your question. |
|
Its becaus @gnarc like to have some more funkitons and for this we/I need the VSAN Mgmt API: CnsQueryVolume Funktion. |
|
You mean this comment and the ones after? I'm not really sure. I've just cloned pyVmomi and ran |
|
Yes. Thanks for the informations :) |
|
I would really like to have this as a part of pyVmomi, I don't know why VMware doesn't simply include it 😩 |
SUMMARY
Add a module to gather infos about first class disks
Fixes #1988
ISSUE TYPE
COMPONENT NAME
vmware.py-> find_first_class_disks(self, datastore_obj)
vmware_first_class_disk_info.py
ADDITIONAL INFORMATION