Skip to content

Commit

Permalink
Removed a test condition that obscured duration (#1364)
Browse files Browse the repository at this point in the history
* removed a function in a test that would obscure if null durations are coming back
it appears this issue is resolved.

* added changelog

---------

Co-authored-by: Demetri <[email protected]>
  • Loading branch information
richp405 and ddimatos authored Apr 4, 2024
1 parent 3d248c4 commit 2697e32
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 4 deletions.
3 changes: 3 additions & 0 deletions changelogs/fragments/1032-clean-job_submit-test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
trivial:
- test_zos_job_submit_func.py - Removed test setting that was covering a missing duration value.
(https://github.com/ansible-collections/ibm_zos_core/pull/1364).
6 changes: 2 additions & 4 deletions tests/functional/modules/test_zos_job_submit_func.py
Original file line number Diff line number Diff line change
Expand Up @@ -695,10 +695,8 @@ def test_job_submit_max_rc(ansible_zos_module, args):
#Expecting: - "The job return code 8 was non-zero in the job output, this job has failed"
# - Consider using module zos_job_query to poll for a long running job or
# increase option \\'wait_times_s` to a value greater than 10.",
if result.get('duration'):
duration = result.get('duration')
else:
duration = 0

duration = result.get('duration')

if duration >= args["wait_time_s"]:
re.search(r'long running job', repr(result.get("msg")))
Expand Down

0 comments on commit 2697e32

Please sign in to comment.