-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Documentation][import handler] Add docstrings to module_utils/import_handler.py #1332
[Documentation][import handler] Add docstrings to module_utils/import_handler.py #1332
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just pointed out a little typo.
@@ -71,10 +109,36 @@ def method(*args, **kwargs): | |||
|
|||
class MissingImport(object): | |||
def __init__(self, import_name=""): | |||
"""Error when it is unable to import a module due it being missing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a little typo: instead of ...module due it being missing.
, it should be ...module due to it being missing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll approve pending Ivan's note: one minor grammar fix.
SUMMARY
Update docstrings on import_handler to the numpy standard
This addresses part of #1311
ISSUE TYPE
COMPONENT NAME
import_handler.py
ADDITIONAL INFORMATION