[v1.10.0] [Enabler] Standardization of choices in modules #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also includes major work on zos_data_set since half of the test suite for zos_archive depends on creating data sets.
This was referenced Apr 5, 2024
Merged
richp405
requested changes
Apr 12, 2024
fernandofloresg
approved these changes
Apr 12, 2024
ketankelkar
approved these changes
Apr 12, 2024
There was a problem hiding this comment.
LGTM- amazing work here Ivan!! Thanks for delivering this mighty effort (which was merely an idea just last week)!!
I've also validated the functionality delivered here while updating (and running) the playbooks in the samples repo.
I think there are some places where stylistic changes could be made, eg:
- instead of removing a call to
upper(), replace it with a call tolower() - leaving params in lower-case until upper is required (eg for certain zoau calls)
But, we should make those as part of other development efforts rather than here. The interface has been updated and I saw no gaps in functionality, so I'd consider this issue completed.
richp405
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Fixes #1360
ISSUE TYPE
COMPONENT NAME
ibm_zos_core
ADDITIONAL INFORMATION