Make the crate include the tool jar ?

[alexsnaps]

From this thread

• Build a .jar for your tool and put it in a crate with a specific version.

• Write templates for Rust parser for trgen. The .toml file for testing would need to reference specific crates for the runtime and tool.

• For testing:

  • Run trgen to instantiate a Rust driver parse app from templates.

  • Build:

    • Load crates.
    • Use sed/awk/Powershell/whatever to grab the version of the runtime tool from the .toml file. Just use "find . -name '*.jar'` to find the loaded Antlr Tool .jar.
    • Run java -jar with the appropriate .jar.
    • Proceed with a Rust compilation.

[alexsnaps]

I wouldn't do that personally. I prefer not using a build.rs to generate source, but rather keep it under source control.
Now I can see that not everyone may agree and that it doesn't invalidate being able to leverage build.rs. So ... ¯_(ツ)_/¯

[rrevenantt]

I am also highly against it. If someone is publishing a rust library crate that depends on antlr runtime, this library absolutely must not require antlr tool and java to be built.

However, i also thought about mentioned usecase and maybe we can do a separate crate to use from build.rs that will be added in [build-dependencies]. It can itself parse toml, check if executable is being built and even download correct tool version.

But either way i don't think this should be a blocker for upstream PR.