Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: provide a possibility of passing custom zoom factor to renderer (not graphics) #244

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Proposal: provide a possibility of passing custom zoom factor to renderer (not graphics) #244

wants to merge 1 commit into from

Conversation

nicky1038
Copy link

@nicky1038 nicky1038 commented Mar 26, 2019 •
edited
Loading

Before this proposal one could pass a custom factor parameter to graphics.scale method BUT calling it directly causes:

  • no redendering;
  • no raising scale event by renderer;
  • no changing of transform.scale.

Of course these actions could be done later in third party code, but in this case it should just repeat the existing renderer.scale method. It's better to allow developers not to do so.

@nicky1038
Proposal: provide a possibility of passing custom zoom factor to rend…
69af9fc 
…erer (not graphics)

Before this proposal one could pass custom factor to 'graphics.scale' BUT calling this method directly causes:
 - no redendering;
 - no raising 'scale' event by renderer;
 - no changing 'transform.scale'.

Of course these actions could be done later in third party code, but in this case it should just repeat the existing 'renderer.scale' method. It's better to allow developers not to do so.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nicky1038