-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support for deletion timestamp added, tests failed #574
base: main
Are you sure you want to change the base?
support for deletion timestamp added, tests failed #574
Conversation
@@ -120,6 +120,13 @@ pub fn reconcile_core(v_replica_set: &VReplicaSet, resp_o: Option<Response<VoidE | |||
if pods_or_none.is_none() { | |||
return (error_state(state), None); | |||
} | |||
if v_replica_set.metadata().has_deletion_timestamp() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you move it to the Init
step? If the VReplicaSet has deletion timestamp, then there is no need to list the pods whatsoever.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem is I cannot align well the code block in k8s controller with the step in anvil. Take the line of code I want to model as an example, I'm not sure if we filter out the entire func (rsc *ReplicaSetController) syncReplicaSet(ctx context.Context, key string)
where should I put the corresponding timestamp checking logic in anvil's model. In other words, I don't know if k8s itself put this part in init
or afterlistpod
step.
Do you have any suggestion?
So the conformance proof passes but the liveness proof breaks, right? |
@Catoverflow could you write some brief descriptions when you open PRs? |
Yes, 2 failed tests are
I'm trying to find a way to expand the |
added |
@Catoverflow You might need to revise the premise of the ESR property to focus on reasoning about VReplicaSet that has no deletion timestamp. You can work with @codyjrivera on that. |
This PR implemented the model & executable part for
https://github.com/kubernetes/kubernetes/blob/master/pkg/controller/replicaset/replica_set.go#L721-L723
Test is still broken, working on fixing that