Repository navigation
test(c/driver/postgresql): use hypothesis to test decimal ingest - #4852
Merged
Merged
Conversation
lidavidm
marked this pull request as ready for review
October 5, 2026 05:44
lidavidm
requested review from
Mandukhai-Alimaa
and removed request for
zeroshade
October 5, 2026 05:44
Comment on lines
+41
to
+46
| @st.composite | ||
| def st_decimal_precision_scale(draw) -> tuple[int, int]: | ||
| precision = draw(st.integers(min_value=1, max_value=38)) | ||
| # TODO: we should also test negative scales | ||
| scale = draw(st.integers(min_value=0, max_value=min(precision, 37))) | ||
| return precision, scale |
Collaborator
There was a problem hiding this comment.
this seems not used?
We keep finding bugs in decimals; try to add another layer of validation.
Mandukhai-Alimaa
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We keep finding bugs in decimals; try to add another layer of validation.