Repository navigation
fix(go/adbc/pkg): treat the "warn" log level as warning - #4881
Merged
Merged
Conversation
"warn", the value the logging help text suggests, fell into an empty case, so ADBC_DRIVER_<PREFIX>_LOG_LEVEL=warn kept the error level. Co-authored-by: Isaac <no-reply@databricks.com>
lidavidm
approved these changes
Oct 12, 2026
lidavidm
pushed a commit
to adbc-drivers/driverbase-go
that referenced
this pull request
Oct 12, 2026
`case "warn":` had no body, so `ADBC_DRIVER_<PREFIX>_LOG_LEVEL=warn`, one of the values the logging help text suggests, kept the error level. Fold it into the `warning` case. Reported in adbc-drivers/spark#96. The template came from apache/arrow-adbc, which has the same bug (apache/arrow-adbc#4881). Generated-by: Isaac <no-reply@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
case "warn":had no body, sowarnkept the error level. Fold it into thewarningcase in the template, and apply the same change to the generated Flight SQL and panicdummy drivers.Closes #4880
Generated-by: Isaac