Skip to content

ARTEMIS-6364 Remove QueueInfo.matchesAddress - #6917

Open
sharanggupta wants to merge 1 commit into
apache:mainfrom
sharanggupta:ARTEMIS-6364
Open

sharanggupta wants to merge 1 commit into
apache:mainfrom
sharanggupta:ARTEMIS-6364

Conversation

@sharanggupta

@sharanggupta sharanggupta commented Nov 16, 2026 •

Copy link
Copy Markdown

Replaces #6899, which GitHub closed after a bad force-push on my side and will not reopen.

QueueInfo.matchesAddress always returned true, so the if around it in PostOfficeImpl.sendQueueInfoToQueue never filtered. As @jbertram suggested in #6899, this removes both and leaves the notification queue's filter from ClusterConnectionBridge#createSelectorFromAddress as the single enforcement point, so behaviour is unchanged.

QueueInfo.matchesAddress always returned true (a 10-year-old typo), so the
cluster-connection address filter in sendQueueInfoToQueue never actually
filtered. The real enforcement is the notification queue's own filter built by
ClusterConnectionBridge#createSelectorFromAddress, which also handles the '!'
exclusion and ',' multiple-address syntax that matchesAddress never implemented.
Remove matchesAddress and its caller so that filter is the single enforcement
point.

Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant