Repository navigation
ARTEMIS-6364 Remove QueueInfo.matchesAddress - #6917
Open
sharanggupta wants to merge 1 commit into
Open
sharanggupta wants to merge 1 commit into
sharanggupta wants to merge 1 commit into
Conversation
QueueInfo.matchesAddress always returned true (a 10-year-old typo), so the cluster-connection address filter in sendQueueInfoToQueue never actually filtered. The real enforcement is the notification queue's own filter built by ClusterConnectionBridge#createSelectorFromAddress, which also handles the '!' exclusion and ',' multiple-address syntax that matchesAddress never implemented. Remove matchesAddress and its caller so that filter is the single enforcement point. Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
sharanggupta
force-pushed
the
ARTEMIS-6364
branch
from
November 16, 2026 18:21
b010bf5 to
b4572fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #6899, which GitHub closed after a bad force-push on my side and will not reopen.
QueueInfo.matchesAddressalways returnedtrue, so theifaround it inPostOfficeImpl.sendQueueInfoToQueuenever filtered. As @jbertram suggested in #6899, this removes both and leaves the notification queue's filter fromClusterConnectionBridge#createSelectorFromAddressas the single enforcement point, so behaviour is unchanged.