Repository navigation
fix(cmake): require all BoringSSL components - #3594
Merged
chenBright merged 1 commit intoOct 10, 2026
Merged
Conversation
Fail during dependency discovery when WITH_BORINGSSL is enabled and required components are missing. Check the include directory, SSL library, and Crypto library separately to avoid reporting success for an incomplete library list.
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
1 open finding
What changed in this PR
This PR tightens BoringSSL dependency discovery in CMake so that enabling WITH_BORINGSSL fails configuration early when any required BoringSSL component is missing.
Changes:
- Make
find_package(BoringSSL)required whenWITH_BORINGSSLis enabled. - Validate BoringSSL include directory, SSL library, and Crypto library independently in the finder module.
| File | Description |
|---|---|
| cmake/FindBoringSSL.cmake | Adjusts find_package_handle_standard_args to require include dir + both SSL/Crypto libraries. |
| CMakeLists.txt | Requires BoringSSL at configure time when WITH_BORINGSSL is enabled. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -63,8 +63,9 @@ set(BORINGSSL_LIBRARIES ${BORINGSSL_SSL_LIBRARY} ${BORINGSSL_CRYPTO_LIBRARY} | |||
|
|
|||
| include(FindPackageHandleStandardArgs) | |||
| find_package_handle_standard_args(BoringSSL DEFAULT_MSG | |||
Copilot stopped reviewing on behalf of
wasphin due to an error
October 9, 2026 16:35
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
When
WITH_BORINGSSLis enabled, missing dependencies do not immediately stop configuration becausefind_package(BoringSSL)is not markedREQUIRED. The finder also validates a combined library list, which can incorrectly report success when the SSL library is missing but the Crypto library is present.What is changed and the side effects?
Changed:
WITH_BORINGSSLis enabled.Side effects:
Check List:
git diff --checkpassed.