Repository navigation
OSS-Fuzz: Add new fuzzer targets concurrency operations - #3679
Open
arthurscchan wants to merge 2 commits into
Open
arthurscchan wants to merge 2 commits into
arthurscchan wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Real-time sampling and reset deadlines prevent fast fuzz inputs from reliably exercising the intended limiter transitions.
1 open issue
What changed in this PR
This PR expands bRPC’s OSS-Fuzz coverage with a target for the automatic concurrency limiter.
Changes:
- Adds fuzz-driven response errors, latencies, and request concurrency values.
- Registers
fuzz_concurrencyin the CMake and OSS-Fuzz build lists.
| File | Description |
|---|---|
| test/fuzzing/oss-fuzz.sh | Includes the new target in OSS-Fuzz builds. |
| test/fuzzing/fuzz_concurrency.cpp | Adds the automatic concurrency limiter fuzz harness. |
| test/CMakeLists.txt | Registers the new CMake fuzz target. |
Review effort: Balanced
arthurscchan
force-pushed
the
brpc-concurrency-fuzzer
branch
from
November 10, 2026 10:28
c4696bf to
f9e8d05
Compare
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
arthurscchan
force-pushed
the
brpc-concurrency-fuzzer
branch
from
November 12, 2026 08:16
f9e8d05 to
0465080
Compare
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
5 open issues
uint8_tandsize_t(and lateruint64_t/int64_t) are used without including standard headers… · NewnullptrintoOnRequestedrisks turning this into a trivial/null-deref fuzzer (depending… · New8, shifts/masks… · New8, shifts/masks… · New8, shifts/masks… · New
1 resolved since last review
Review effort: Lite
Signed-off-by: Arthur Chan <arthur.chan@adalogics.com>
arthurscchan
force-pushed
the
brpc-concurrency-fuzzer
branch
from
November 12, 2026 10:08
0465080 to
1d2b7ec
Compare
Copilot stopped reviewing on behalf of
wwbmmm due to an error
November 12, 2026 10:49
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
3 open issues
butil::cpuwide_time_us()introduces non-determinism into the fuzzer execution (seed corpus… · New(i & 7) == 0periodic tick is a magic constant that’s not explained. Please extract7/8… · New
5 resolved since last review
uint8_tandsize_t(and lateruint64_t/int64_t) are used without including standard headers…8, shifts/masks…8, shifts/masks…8, shifts/masks…nullptrintoOnRequestedrisks turning this into a trivial/null-deref fuzzer (depending…
Review effort: Lite
| // | ||
| // Each 8-byte record is big-endian and decoded as: | ||
| // bits 0..7 error_code | ||
| // bits 8..15 request-tick flag (bit 8 / 0x100) |
| } | ||
|
|
||
| brpc::policy::AutoConcurrencyLimiter limiter; | ||
| int64_t now_us = butil::cpuwide_time_us(); |
| static_cast<int64_t>((v >> kLatencyShift) & kLatencyMask); | ||
| limiter.AddSample(error_code, latency_us, now_us); | ||
| limiter.MaxConcurrency(); | ||
| if ((v & (1ULL << kRequestFlagBit)) || (i & 7) == 0) { |
Copilot stopped reviewing on behalf of
wwbmmm due to an error
November 12, 2026 13:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new OSS-Fuzz fuzzer targets concurrency operations, aiming to improve the overall fuzzing coverage and effectiveness of project brpc.