Repository navigation
CAMEL-26699: camel-jbang - the chaos mark of an exchange on the Activity tab is not cut - #29362
Conversation
…ity tab is not cut Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
gnodet-bot
left a comment
There was a problem hiding this comment.
LGTM. No issues found.
The root cause is correctly identified: shortExchangeId() truncates to 6 chars before …- then appends the counter without leading zeros, so a counter like 104E (4 hex chars) produces a 12-column display string vs 1E (2 chars) that produces 10. Add the 2-column dice emoji and trailing rule tag and the 16-column floor is breached.
The fix is correct:
exchangeWidthis initialized to 16 (the previous hardcoded floor) and updated lazily per-entry during the row-build loopChaosMarks.ruleOf()is cached intoruleand reused for the cell, avoiding a redundant call — nice incidental cleanupCharWidth.of()is consistent with the same idiom used inSourceLiveColumn,TuiHelper, andLogTab- The column's
.widths()applies to both header and data rows, so both are widened together
Pre-fix validation: ✅ — The old test used 3F2A85F3D4213-0000000000000001E (short form 3F2A85…-1E, display width 15 with mark, fits in 16 cols). The new test uses 3F2A85F3D4213-000000000000104E (short form 3F2A85…-104E, display width 17, overflows 16 cols before the fix). The test correctly fails without the fix and passes with it.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
|
🧪 CI tested the following changed modules:
🔁 1 test passed only after a retry on JDK 21 (1 retried attempt) Recovered flaky tests on JDK 21 (1)
🔬 Scalpel shadow comparison — Scalpel: 2 of 717 tested, 1 compile-only — current: 2 all testedMaveniverse Scalpel detected 2 affected modules (current approach: 2). Skip-tests mode would test 2 modules (1 direct + 1 downstream), skip tests for 1 (generated code, meta-modules) Modules Scalpel would test (2)
Modules with tests skipped (1)
All tested modules (3 modules, 0.9s total)Total reactor time: 0.9s
Top 20 slowest modules:
|
CAMEL-26699, found in the hands-on round: on the Activity tab the chaos mark of a faulted exchange was cut to
🎲r. The EXCHANGE column was 16 wide, and a real short id (3F2A85…-104E, 12 columns) plus the mark (🎲r1, with a 2-column dice) needs 17 or more. The column is now as wide as its widest marked exchange, and at least 16 as before.The test used an id whose short form was 2 characters shorter than a real one (
…-1E), which is why it passed. It now uses a realistic id.Tests:
ChaosMarksTest,ActivityTab*TestandSourceSizeTestpass.Claude Code on behalf of Claus Ibsen
🤖 Generated with Claude Code
https://claude.ai/code/session_012nJsFsjqqFiwroeHRWaKbS