Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](cloud-mow) FE should release delete bitmap lock when calculating delete bitmap failed #45673 #46650

Open
wants to merge 1 commit into
base: branch-3.0
Choose a base branch
from

Conversation

hust-hhb
Copy link
Contributor

@hust-hhb hust-hhb commented Jan 8, 2025

pick pr #45673

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 8, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@hust-hhb
Copy link
Contributor Author

hust-hhb commented Jan 8, 2025

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 41171 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 722c99352988db186db63c09d7014e20f687392a, data reload: false

------ Round 1 ----------------------------------
q1	17579	7319	7219	7219
q2	2060	165	160	160
q3	10574	1120	1136	1120
q4	10257	794	738	738
q5	8097	2866	2920	2866
q6	235	152	149	149
q7	1005	622	629	622
q8	9512	2005	2024	2005
q9	6781	6495	6502	6495
q10	7784	2333	2322	2322
q11	459	264	268	264
q12	397	210	206	206
q13	17772	2972	2981	2972
q14	252	206	213	206
q15	572	507	528	507
q16	673	612	618	612
q17	953	570	617	570
q18	7398	6693	6692	6692
q19	1388	1042	1091	1042
q20	498	203	196	196
q21	4009	3283	3225	3225
q22	1099	983	1023	983
Total cold run time: 109354 ms
Total hot run time: 41171 ms

----- Round 2, with runtime_filter_mode=off -----
q1	7288	7399	7215	7215
q2	327	236	245	236
q3	3087	2993	2952	2952
q4	2073	1764	1819	1764
q5	5698	5759	5704	5704
q6	224	134	136	134
q7	2165	1777	1818	1777
q8	3373	3493	3464	3464
q9	8839	8907	8900	8900
q10	3602	3521	3550	3521
q11	599	502	498	498
q12	780	588	631	588
q13	7405	3150	3108	3108
q14	288	270	259	259
q15	555	504	509	504
q16	713	647	636	636
q17	1770	1547	1539	1539
q18	7776	7588	7336	7336
q19	1645	1588	1548	1548
q20	2055	1776	1809	1776
q21	5469	5138	5197	5138
q22	1130	1021	1009	1009
Total cold run time: 66861 ms
Total hot run time: 59606 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 192201 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 722c99352988db186db63c09d7014e20f687392a, data reload: false

query1	960	369	365	365
query2	6519	2107	2115	2107
query3	6700	226	216	216
query4	33493	23555	23432	23432
query5	4366	455	455	455
query6	276	188	180	180
query7	4640	307	310	307
query8	292	232	230	230
query9	9803	2681	2656	2656
query10	502	268	261	261
query11	18073	15039	15261	15039
query12	153	109	101	101
query13	1644	437	414	414
query14	8742	6554	7521	6554
query15	259	172	194	172
query16	8144	460	475	460
query17	1666	551	536	536
query18	2126	299	310	299
query19	373	153	146	146
query20	114	104	104	104
query21	206	101	102	101
query22	4806	4669	4607	4607
query23	37170	34327	34193	34193
query24	11638	2825	2816	2816
query25	549	399	392	392
query26	1167	171	168	168
query27	2865	340	340	340
query28	8020	2412	2414	2412
query29	659	433	423	423
query30	336	173	165	165
query31	1010	783	825	783
query32	104	58	61	58
query33	786	295	285	285
query34	945	510	532	510
query35	872	704	713	704
query36	1121	939	956	939
query37	120	73	74	73
query38	4017	3853	3843	3843
query39	1512	1444	1454	1444
query40	288	102	103	102
query41	55	51	50	50
query42	123	101	100	100
query43	548	500	479	479
query44	1317	823	815	815
query45	180	172	176	172
query46	1152	710	721	710
query47	1981	1883	1892	1883
query48	459	375	396	375
query49	1313	412	406	406
query50	815	419	408	408
query51	7204	6996	7110	6996
query52	101	98	90	90
query53	263	186	186	186
query54	1210	472	469	469
query55	83	82	80	80
query56	279	258	256	256
query57	1239	1142	1116	1116
query58	242	211	217	211
query59	3221	3030	3231	3030
query60	298	268	268	268
query61	133	131	129	129
query62	869	679	677	677
query63	224	194	191	191
query64	5180	752	738	738
query65	3315	3211	3204	3204
query66	1328	324	324	324
query67	16097	15762	15705	15705
query68	5031	577	575	575
query69	447	275	273	273
query70	1200	1042	1104	1042
query71	342	259	262	259
query72	6207	4123	4024	4024
query73	753	351	344	344
query74	10566	9183	9097	9097
query75	3399	2640	2635	2635
query76	2968	1123	1107	1107
query77	388	273	277	273
query78	10590	9733	9539	9539
query79	1298	588	593	588
query80	1059	438	431	431
query81	553	235	236	235
query82	1106	120	118	118
query83	224	148	142	142
query84	243	80	80	80
query85	1281	313	293	293
query86	379	301	290	290
query87	4451	4455	4379	4379
query88	3629	2415	2358	2358
query89	410	295	299	295
query90	1961	189	183	183
query91	185	150	146	146
query92	59	52	54	52
query93	1052	543	550	543
query94	925	293	276	276
query95	358	253	255	253
query96	610	280	289	280
query97	3295	3152	3194	3152
query98	209	202	203	202
query99	1544	1297	1277	1277
Total cold run time: 302987 ms
Total hot run time: 192201 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 33.06 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 722c99352988db186db63c09d7014e20f687392a, data reload: false

query1	0.03	0.03	0.03
query2	0.06	0.03	0.03
query3	0.23	0.06	0.06
query4	1.64	0.10	0.10
query5	0.52	0.53	0.52
query6	1.15	0.73	0.72
query7	0.02	0.01	0.01
query8	0.04	0.04	0.03
query9	0.58	0.51	0.49
query10	0.56	0.54	0.56
query11	0.15	0.10	0.11
query12	0.14	0.11	0.12
query13	0.61	0.59	0.58
query14	2.93	3.10	2.93
query15	0.89	0.83	0.82
query16	0.38	0.38	0.38
query17	1.06	1.03	1.06
query18	0.24	0.21	0.22
query19	1.91	1.92	1.93
query20	0.01	0.01	0.01
query21	15.35	0.57	0.57
query22	2.73	2.18	1.63
query23	17.12	0.89	0.92
query24	3.01	1.17	2.48
query25	0.31	0.26	0.05
query26	0.44	0.14	0.14
query27	0.05	0.04	0.05
query28	9.13	1.11	1.07
query29	12.58	3.20	3.17
query30	0.24	0.06	0.06
query31	2.87	0.39	0.39
query32	3.25	0.46	0.47
query33	2.98	3.03	3.02
query34	17.07	4.51	4.48
query35	4.59	4.50	4.57
query36	0.67	0.51	0.52
query37	0.09	0.06	0.05
query38	0.05	0.03	0.03
query39	0.03	0.02	0.02
query40	0.16	0.13	0.12
query41	0.08	0.03	0.02
query42	0.03	0.02	0.02
query43	0.03	0.03	0.03
Total cold run time: 106.01 s
Total hot run time: 33.06 s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants