Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Add initialization list to the copy constructor of ScanPredicate in jni_connect.h #46666

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

Tech-Circle-48
Copy link
Contributor

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
The copy constructor of ScanPredicate in jni_connect.h does not use an initialization list, which might result in uninitialized member variables or unintended behavior.

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason
  • Behavior changed:

    • No.
    • Yes.
  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Jan 9, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@Tech-Circle-48
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TPC-H: Total hot run time: 32685 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 09de2728859afbacfb77dd32f0a0e99a817ad660, data reload: false

------ Round 1 ----------------------------------
q1	17594	6123	6028	6028
q2	2044	298	180	180
q3	10451	1222	740	740
q4	10236	890	436	436
q5	8125	2184	1975	1975
q6	208	186	150	150
q7	904	762	617	617
q8	9843	1343	1221	1221
q9	5270	4884	4995	4884
q10	6778	2304	1836	1836
q11	489	277	256	256
q12	339	356	213	213
q13	18080	3680	3105	3105
q14	236	235	212	212
q15	574	518	500	500
q16	628	610	593	593
q17	556	851	321	321
q18	6970	6429	6446	6429
q19	1590	958	547	547
q20	317	310	184	184
q21	2812	2208	1959	1959
q22	355	327	299	299
Total cold run time: 104399 ms
Total hot run time: 32685 ms

----- Round 2, with runtime_filter_mode=off -----
q1	6183	6159	6219	6159
q2	235	332	240	240
q3	2261	2647	2323	2323
q4	1415	1815	1345	1345
q5	4314	4729	4807	4729
q6	180	173	142	142
q7	2112	1963	1869	1869
q8	2637	2801	2696	2696
q9	7244	7197	7285	7197
q10	3027	3375	2770	2770
q11	582	506	515	506
q12	671	790	645	645
q13	3463	3944	3244	3244
q14	283	314	306	306
q15	558	526	484	484
q16	646	692	665	665
q17	1223	1718	1254	1254
q18	7738	7495	7282	7282
q19	827	1166	1070	1070
q20	1988	2016	1993	1993
q21	5672	5319	4971	4971
q22	617	624	588	588
Total cold run time: 53876 ms
Total hot run time: 52478 ms

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 38.86% (10128/26061)
Line Coverage: 29.91% (85673/286476)
Region Coverage: 29.01% (43720/150707)
Branch Coverage: 25.55% (22317/87342)
Coverage Report: http://coverage.selectdb-in.cc/coverage/09de2728859afbacfb77dd32f0a0e99a817ad660_09de2728859afbacfb77dd32f0a0e99a817ad660/report/index.html

@doris-robot
Copy link

TPC-DS: Total hot run time: 194060 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 09de2728859afbacfb77dd32f0a0e99a817ad660, data reload: false

query1	1280	959	907	907
query2	6370	2323	2416	2323
query3	10927	4649	4859	4649
query4	32777	23442	23163	23163
query5	4088	610	471	471
query6	278	206	188	188
query7	3992	474	315	315
query8	307	243	255	243
query9	9522	2660	2644	2644
query10	446	300	258	258
query11	17839	15216	14938	14938
query12	155	113	103	103
query13	1581	551	424	424
query14	10703	7112	6609	6609
query15	245	208	199	199
query16	8095	623	406	406
query17	1590	741	617	617
query18	2162	410	308	308
query19	200	192	154	154
query20	118	141	114	114
query21	208	129	115	115
query22	4734	4357	4389	4357
query23	34394	33443	33313	33313
query24	6454	2270	2310	2270
query25	477	449	404	404
query26	798	271	153	153
query27	2009	462	338	338
query28	5097	2455	2451	2451
query29	646	567	434	434
query30	204	178	149	149
query31	960	878	809	809
query32	82	56	61	56
query33	479	347	294	294
query34	765	838	502	502
query35	765	832	757	757
query36	1031	1030	984	984
query37	120	136	81	81
query38	4283	4249	4127	4127
query39	1505	1450	1452	1450
query40	208	118	113	113
query41	47	48	43	43
query42	122	100	106	100
query43	531	530	496	496
query44	1299	814	850	814
query45	180	177	164	164
query46	874	1069	648	648
query47	1906	1889	1858	1858
query48	395	409	317	317
query49	714	488	398	398
query50	648	665	380	380
query51	6940	7096	6976	6976
query52	104	95	95	95
query53	224	248	186	186
query54	493	509	416	416
query55	85	84	75	75
query56	261	259	256	256
query57	1201	1202	1121	1121
query58	264	226	218	218
query59	3118	3468	3113	3113
query60	285	276	255	255
query61	108	101	105	101
query62	860	780	708	708
query63	229	197	188	188
query64	3330	1011	675	675
query65	3274	3315	3256	3256
query66	892	416	301	301
query67	16200	15862	15397	15397
query68	8446	704	515	515
query69	482	292	254	254
query70	1181	1126	1081	1081
query71	440	317	258	258
query72	6242	3865	3895	3865
query73	651	745	355	355
query74	9828	8917	8750	8750
query75	4000	3112	2642	2642
query76	3579	1125	779	779
query77	760	374	294	294
query78	10042	10159	9512	9512
query79	3430	803	615	615
query80	651	511	436	436
query81	469	257	238	238
query82	583	152	117	117
query83	194	164	140	140
query84	296	87	65	65
query85	780	355	299	299
query86	346	273	312	273
query87	4275	4409	4386	4386
query88	4517	2138	2168	2138
query89	419	324	284	284
query90	1887	188	190	188
query91	134	132	103	103
query92	70	57	52	52
query93	1662	862	537	537
query94	642	392	277	277
query95	334	261	256	256
query96	484	608	277	277
query97	2882	2935	2774	2774
query98	221	197	194	194
query99	1671	1483	1361	1361
Total cold run time: 294076 ms
Total hot run time: 194060 ms

@doris-robot
Copy link

ClickBench: Total hot run time: 30.55 s
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/clickbench-tools
ClickBench test result on commit 09de2728859afbacfb77dd32f0a0e99a817ad660, data reload: false

query1	0.03	0.03	0.03
query2	0.07	0.04	0.04
query3	0.24	0.07	0.07
query4	1.61	0.10	0.10
query5	0.42	0.43	0.42
query6	1.17	0.66	0.68
query7	0.03	0.01	0.01
query8	0.04	0.03	0.04
query9	0.56	0.51	0.50
query10	0.56	0.58	0.54
query11	0.14	0.10	0.10
query12	0.14	0.11	0.11
query13	0.60	0.61	0.59
query14	2.74	2.72	2.72
query15	0.89	0.82	0.81
query16	0.38	0.38	0.38
query17	0.98	0.98	1.01
query18	0.24	0.21	0.20
query19	1.90	1.76	2.04
query20	0.01	0.01	0.02
query21	15.36	0.94	0.58
query22	0.73	0.78	0.65
query23	15.28	1.41	0.50
query24	2.60	0.39	1.09
query25	0.19	0.18	0.19
query26	0.27	0.16	0.13
query27	0.05	0.04	0.06
query28	13.75	1.54	1.07
query29	12.58	3.87	3.25
query30	0.24	0.09	0.06
query31	2.83	0.58	0.38
query32	3.23	0.54	0.47
query33	3.10	3.06	3.16
query34	16.69	5.05	4.48
query35	4.49	4.47	4.46
query36	0.63	0.48	0.49
query37	0.10	0.06	0.06
query38	0.05	0.04	0.03
query39	0.04	0.02	0.03
query40	0.17	0.14	0.13
query41	0.08	0.02	0.02
query42	0.04	0.03	0.02
query43	0.04	0.04	0.03
Total cold run time: 105.29 s
Total hot run time: 30.55 s

Copy link
Contributor

github-actions bot commented Jan 9, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jan 9, 2025
Copy link
Contributor

github-actions bot commented Jan 9, 2025

PR approved by anyone and no changes requested.

Yukang-Lian

This comment was marked as spam.

@morningman morningman merged commit 19554ce into apache:master Jan 9, 2025
30 of 33 checks passed
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
…e in jni_connect.h (#46666)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
The copy constructor of `ScanPredicate` in `jni_connect.h` does not use
an initialization list, which might result in uninitialized member
variables or unintended behavior.
github-actions bot pushed a commit that referenced this pull request Jan 9, 2025
…e in jni_connect.h (#46666)

### What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:
The copy constructor of `ScanPredicate` in `jni_connect.h` does not use
an initialization list, which might result in uninitialized member
variables or unintended behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.x dev/3.0.x reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants