Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36985]remove Catalog.ColumnAlreadyExistException when apply applyAddColumnEventWithPosition in paimon #3828

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hiliuxg
Copy link
Contributor

@hiliuxg hiliuxg commented Jan 1, 2025

remove Catalog.ColumnAlreadyExistException when apply applyAddColumnEventWithPosition in paimon. because use may create table already before with the target column.

…ventWithPosition in paimon. because use may create table already before with the target column.
…ventWithPosition in paimon. because use may create table already before with the target column.
@@ -293,7 +293,11 @@ private void applyDropColumn(DropColumnEvent event) throws SchemaEvolveException
} catch (Catalog.TableNotExistException
| Catalog.ColumnAlreadyExistException
| Catalog.ColumnNotExistException e) {
throw new SchemaEvolveException(event, e.getMessage(), e);
if (e instanceof Catalog.ColumnAlreadyExistException) {
LOG.warn("{}, skip it.", e.getMessage());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add this check in applyAddColumnWithBeforePosition and applyAddColumn method?

…ventWithPosition in paimon. because use may create table already before with the target column.
Copy link
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@lvyanquan
Copy link
Contributor

@leonardBang @ruanhang1993 could you please help to trigger the CI?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants