Repository navigation
Conversation
- RexCallConverterFactory: add converter entries for NOT, IS FALSE, IS NOT TRUE, IS NOT FALSE (default name mapping to the flinksql- registered functions; NOT overwrites the baseline via the same name in the vector function tier) IS TRUE keeps the original IsTrueRexCallConverter.
lgbo-ustc
approved these changes
Oct 27, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes are proposed in this pull request?
Fixes #13457
Maps the Flink logical expressions to their velox flinksql implementations (companion velox PR bigo-sg/velox#90):
RexCallConverterFactory:NOT/IS FALSE/IS NOT TRUE/IS NOT FALSEentries — direct name mappings; these previously failed planning with "Function not supported".IS TRUEkeeps its existingIsTrueRexCallConverter(unchanged).The
is_*names exist only in the velox flinksql namespace (companion PR), so landing order / version pairing matters;notexists in the baseline and the companion PR registers a behavior-identical flinksql vector function under the same name, moving dialect ownership of the runtime path.How was this patch tested?
RexNodeConverterTest2/2; streaming operator suites (filter 8 run / 0 fail / 3 pre-existing skips; project 1/1).IS NOT TRUEfilters, planner-absorbedNOT, nested forms, boolean-family regression. One GROUP BY case excluded — pre-existing keyed-aggregation defect, reproduced identically before this change.