Repository navigation
[branch-2.5] HBASE-30538 Bump snappy-java to 1.1.10.12 - #8875
Open
nirdosh0110 wants to merge 3 commits into
Open
nirdosh0110 wants to merge 3 commits into
nirdosh0110 wants to merge 3 commits into
Conversation
snappy-java 1.1.10.9 added an output-space check in Snappy.compress(ByteBuffer, ByteBuffer) based on remaining(), which rejects Hadoop SnappyCompressor (output limit(0) before compress) and breaks writes through Hadoop SnappyCodec. Fixed in 1.1.10.11 (apache#766); 1.1.10.12 also fixes apache#767. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> (cherry picked from commit 4a04384)
Fails with snappy-java 1.1.10.9/1.1.10.10 ('not enough space for
output'), passes with 1.1.10.11+.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
(cherry picked from commit a2cfc21)
Hadoop's SnappyCodec only uses snappy-java since 3.3.1 (HADOOP-17125). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Umeshkumar9414
added
the
backport
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #8870 to branch-2.5. https://issues.apache.org/jira/browse/HBASE-30538
Bumps snappy-java 1.1.10.9 -> 1.1.10.12 and adds
TestHadoopSnappyCodec. Resolved a trivial pom.xml conflict (xz.versionis still defined next tosnappy.versionon branch-2.5).The test is skipped when Hadoop is older than 3.3.1, since Hadoop's
SnappyCodeconly uses snappy-java from 3.3.1 on (HADOOP-17125) and needs the native library before that. As suggested in #8870 (comment).Verified locally on branch-2.5:
-Dhadoop.profile=3.0(Hadoop 3.4.3): pass-Dhadoop.profile=3.0 -Dsnappy.version=1.1.10.9: fails withnot enough space for output: need 254,857 bytes, but only 0 remaining🤖 Generated with Claude Code