You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
GenericHelixControler.getLeaderController does not check for potential conrtroller's _helixMapper's nullity #2963
Plain old NPE.
Depending on the order of the controllers in the set of existing controllers, and especially depending on the position of the "leader" controller in the collection, some controllers prior to the "leader" one may still have their _helixMapper field set to null, resulting with an NPE while filtering for leader.
To Reproduce
Happens from time to time, depending on the ordering of the retrieved controllers in the collection.
Expected behavior
controllers without _helixMapper set cannot be leaders, so we could expect them to be filtered out during the search.
Here is the code I propose to change (in GenericHelixController.java):
public static GenericHelixController getLeaderController(String clusterName) {
if (clusterName != null) {
ImmutableSet<GenericHelixController> controllers = _helixControllerFactory.get(clusterName);
if (controllers != null) {
return controllers.stream().filter(controller -> controller._helixManager.isLeader())
.findAny().orElse(null);
}
}
return null;
}
Activity
jacob-netguardians commentedon Nov 18, 2024
PR could be created (I don't have that sort of right, sorry, still a newbie here) from that branch here: https://github.com/jacob-netguardians/helix/tree/bugfix/2963-fix-npe-while-rebalancing-task
apache#2963 NPE fixing
apache#2963 NPE fixing
apache#2963 Fix NPE during task rebalancing
apache#2963 Fix NPE during task rebalancing
apache#2963 Fix NPE during task rebalancing
Revert "apache#2963 Fix NPE during task rebalancing"
apache#2963 Fix NPE during task rebalancing