Repository navigation
Spark: Emit geometry bounds in Parquet writers - #18501
Open
huan233usc wants to merge 5 commits into
Open
huan233usc wants to merge 5 commits into
huan233usc wants to merge 5 commits into
Conversation
Generated-by: Codex
Share the geospatial WKB write path while preserving existing metrics builder signatures. Generated-by: Codex
added 3 commits
October 14, 2026 13:32
Keep the existing geometry counters while sharing the binary metrics contract with Spark writers. Generated-by: Codex
Preserve shared WKB writes through a private metrics hook and keep the core metrics API unchanged. Generated-by: Codex
Use shared assertions for all-null and empty WKB inputs while checking their distinct counts and byte totals. Generated-by: Codex
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spark 4.1 and 4.2 Parquet writers currently emit value-size metrics for geometry but omit its spatial bounds. Keep the shared geospatial WKB write path and let each private writer update its existing metrics builder: geometry uses
GeometryFieldMetrics.Builderfor XY bounds, while geography retains size-only metrics. Preserve the CRS from the Parquet annotation, null counts, and byte totals. Spark 4.2 continues to slice the original WKB payload to preserve byte order. Core metrics classes and public APIs are unchanged.Test plan:
TestSparkParquetWriteron 4.1 and 4.2 (9 each). Covers file bounds, null/empty inputs, CRS, byte totals, and WKB round-trips.assemble,spotlessCheck,checkstyleMain, andcheckstyleTest.AI Disclosure