Conversation
The destination handshake left SO_RCVTIMEO at one second on the socket later used by APPLYBATCH. Slow-but-successful writes therefore surfaced as EAGAIN and aborted migration. Use a bounded mutable timeout and reapply it before each batch so CONFIG SET takes effect immediately. Model: gpt-5.6-sol Co-Authored-By: Codex (gpt-5.6-sol) <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
migrate-response-timeout-msconfiguration with a 5000 ms default and a 1000-300000 ms rangeAPPLYBATCHThis is the timeout-only split from #3613. It intentionally excludes the subkey-iterator optimization.
Motivation
Slot migration currently sets
SO_RCVTIMEOto one second while checking destination responses, then reuses that socket forAPPLYBATCH. A production canary failed after about 1.14 seconds withResource temporarily unavailableeven though the destination was lightly loaded. This indicates anEAGAINreceive timeout rather than destination saturation.An explicit bounded setting lets operators test a longer response deadline without introducing low-level retries. Reapplying it before every batch also makes
CONFIG SET migrate-response-timeout-ms ...effective during an active migration.Validation
./x.py check format --clang-format-path clang-format-18kvrocksandunittesttargets./build/unittest --gtest_filter="IOUtil.SockReadLineWaitsForConfiguredReceiveTimeout:Config.GetAndSet": 2 tests passedgit diff --check🤖 Generated with Codex (gpt-5.6-sol)