Jackpot 31 based on NetBeans 31 - #50
Conversation
lahodaj
left a comment
lahodaj
left a comment
There was a problem hiding this comment.
Looks good to me. (Assuming tests pass.) Thanks!
|
the maven / tools seems tested ok. well I see some error but I have no clue it was before or not. |
|
oh. the job doesn't have an action which checks for test failures and the junit task is probably run with failOnError=false. Since tests failed and everything is still green. I didn't check the logs before approving - sorry. |
|
The tests also verify that the testing framework in Jackpot works correctly, and do a nested JUnit run. And some of these nested JUnit runs fail intentionally. I believe this is the case here. So, I wouldn't worry about the log containing seemingly failing JUnit tests, as long as the job itself is not reporting failures. Thanks! |
|
Ok lets merge |
3 participants
trying to update to released version of NetBeans (using dlcdn for speed)
Jdk 21 is baseline, not able to get openjdk 26 so doing only 21 and 25
fixed notice.
fixed webapp/pom.xml for more modern lib
tested setup/java but the java home is something with temurin inside instead of openjdk something