Conversation
…t lists Query.getResultList() copies the kernel ResultList into an ArrayList since the Jakarta Persistence 3.2 work, so the complete result is materialized and openjpa.FetchBatchSize no longer streams rows to the caller. Keep that as the default and add the MaterializeQueryResultList compatibility option, which restores the lazy ResultList for applications that rely on streaming, and document the memory implication in the migration considerations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the Jakarta Persistence 3.2 work
Query.getResultList()copies the kernelResultListinto anArrayList, so results are always fully materialized andopenjpa.FetchBatchSizeno longer streams rows to the caller (measured: with a batch size the kernel returns a lazyWindowResultListwhich the copy drains). The eager copy came from TCK compliance work rather than a spec clause we could cite, so it stays the default and the newMaterializeQueryResultListcompatibility option restores the lazy list. The migration guide now spells out the memory implication and documents the option.