Conversation
…n name Section 11.1.35 requires the default map key column to be named <field>_KEY, which does not match schemas created by earlier releases (where the default was "key", usually materialized as "KEY0"). Gate the default name derivation behind the new compatibility option UseSpecDefaultMapKeyColumnName. It defaults to true, so the spec name is used out of the box; setting it to false restores the old default. An explicit @MapKeyColumn is unaffected either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The spec default for a map key column (
<field>_KEY, section 11.1.35) silently changes DDL against schemas created by earlier releases, where the column wasKEY/KEY0. The derivation now goes through one helper gated by the newUseSpecDefaultMapKeyColumnNameoption, which defaults to the spec name and can be turned off so upgrades keep working; an explicit@MapKeyColumnis unaffected either way.TestContainerSpecCompatibilityOptionscovers both defaults, and the migration guide and mapping overview document the option.