Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPENNLP-1689 - Update GH actions with ASF #builds security recommendtions #736

Merged

Conversation

rzo1
Copy link
Contributor

@rzo1 rzo1 commented Jan 6, 2025

For all changes:

  • Is there a JIRA ticket associated with this PR? Is it referenced
    in the commit message?

  • Does your PR title start with OPENNLP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.

  • Has your PR been rebased against the latest commit within the target branch (typically main)?

  • Is your initial contribution a single, squashed commit?

For code changes:

  • Have you ensured that the full suite of tests is executed via mvn clean install at the root opennlp folder?
  • Have you written or updated unit tests to verify your changes?
  • If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under ASF 2.0?
  • If applicable, have you updated the LICENSE file, including the main LICENSE file in opennlp folder?
  • If applicable, have you updated the NOTICE file, including the main NOTICE file found in opennlp folder?

For documentation related changes:

  • Have you ensured that format looks appropriate for the output in which it is rendered?

Note:

Adjust GH workflow to avoid persisting credentials according to https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=321719166#GitHubActionsSecurity-Dangerousworkflows found via "zizmor" static GH action analysis.

➜  workflows git:(main) ✗ zizmor maven.yml publish-snapshots.yml 
2025-01-06T07:43:52.127796Z  INFO audit: zizmor: 🌈 completed /Users/rz/IdeaProjects/opennlp/.github/workflows/maven.yml
2025-01-06T07:43:52.133229Z  INFO audit: zizmor: 🌈 completed /Users/rz/IdeaProjects/opennlp/.github/workflows/publish-snapshots.yml

@rzo1 rzo1 requested review from kinow, jzonthemtn and mawiesne January 6, 2025 07:48
@rzo1 rzo1 self-assigned this Jan 6, 2025
@rzo1 rzo1 merged commit 75e1df6 into main Jan 6, 2025
7 checks passed
@rzo1 rzo1 deleted the OPENNLP-1689---Enhance-GH-action-setup-by-#builds-recommendation- branch January 6, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants