Skip to content

fix(ozone): add isTrue() to bare assertThat in testCaching #11119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
shoemoney wants to merge 1 commit into from
Closed

fix(ozone): add isTrue() to bare assertThat in testCaching #11119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...e/integration-test/src/test/java/org/apache/hadoop/hdds/scm/TestXceiverClientManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public void testCaching(boolean securityEnabled, @TempDir Path metaDir) throws I
assertEquals(1, client1.getRefcount());
// although allowShortCircuit true when calling acquireClientForReadData,
// XceiverClientGrpc client will be allocated since short-circuit is by default disabled.
assertThat(client1 instanceof XceiverClientGrpc);
assertThat(client1 instanceof XceiverClientGrpc).isTrue();

ContainerWithPipeline container2 = storageContainerLocationClient
.allocateContainer(
Expand All @@ -100,7 +100,7 @@ public void testCaching(boolean securityEnabled, @TempDir Path metaDir) throws I
XceiverClientSpi client2 = clientManager
.acquireClient(container2.getPipeline());
assertEquals(1, client2.getRefcount());
assertThat(client2 instanceof XceiverClientGrpc);
assertThat(client2 instanceof XceiverClientGrpc).isTrue();

XceiverClientSpi client3 = clientManager
.acquireClient(container1.getPipeline());
Expand Down