Skip to content

HDDS-17709. Restore pull_request trigger on master - #11944

Closed
adoroszlai wants to merge 1 commit into
apache:masterfrom
adoroszlai:HDDS-17709
Closed

adoroszlai wants to merge 1 commit into
apache:masterfrom
adoroszlai:HDDS-17709

Conversation

@adoroszlai

@adoroszlai adoroszlai commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

What changes were proposed in this pull request?

Fork CI Status mirrors post-commit.yml, so status appears as a single check. I think it should mirror ci.yml for more detailed checks in the PR summary. But the real runs in fork are listed under post-commit.yml (and I get the same impression by listing runs via gh CLI), so it may not work.

Also, it would be nice to get more detailed output from fork-ci action in the workflow run. Currently it only shows errors and a summary: Fork CI: 42 processed, 30 checks written, 0 failed.

This change partially reverts #11871: re-enable the pull_request trigger on master, but keeps the Fork CI Status workflow so we can continue refining it.

https://issues.apache.org/jira/browse/HDDS-17709

@chihsuan chihsuan left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up! @adoroszlai Restoring full CI for now makes sense.

Just a note: we removed dependabot** from push.branches-ignore in #11871, so dependabot PRs may run CI twice now. Probably minor since this is temporary, so your call. 🙂

@adoroszlai
adoroszlai marked this pull request as draft November 5, 2026 20:22

@smengcl smengcl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adoroszlai

- master
# - master
push:
branches-ignore:

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since pull_request runs for master again, should we also bring back 'dependabot**' here? #11871 dropped it from this list because dependabot PRs no longer had a pull_request run. Without it, each dependabot PR to master gets two full CI runs: one for the push to its branch in apache/ozone (concurrency group ci-<sha>) and one for the PR (ci-<PR number>), so neither cancels the other.

    branches-ignore:
      # only master, builds on schedule
      - master
      - 'dependabot**'

@adoroszlai

Copy link
Copy Markdown
Contributor Author

Thanks @chihsuan, @smengcl for the review. I'm leaning towards not restoring the trigger. While showing status as a single check is not ideal, it is better than queueing for several hours. I'll keep this open but would prefer to continue with the other PRs. Please take a look at:

@adoroszlai adoroszlai closed this Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants