-
Notifications
You must be signed in to change notification settings - Fork 511
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-12012. Defer ozone repair prompt after subcommand validation #7653
base: master
Are you sure you want to change the base?
Conversation
Hi @adoroszlai. Please resolve the conflicts. |
@sarvekshayr updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @adoroszlai for the patch. The output is clear now.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch @adoroszlai , LGTM!
What changes were proposed in this pull request?
ozone repair
shows warning prompt on startup. HDDS-11945 added logic to skip it when showing top-level usage.This PR further improves it by deferring the prompt to subcommands, so that it is not shown for:
--help
Integration tests running
ozone repair
now need to passy
to stdin.https://issues.apache.org/jira/browse/HDDS-12012
How was this patch tested?
CI:
https://github.com/adoroszlai/ozone/actions/runs/12637496667