GH-3820: Exercise explicit binary statistics truncation - #3821
Open
dhruv-15-03 wants to merge 1 commit into
Open
dhruv-15-03 wants to merge 1 commit into
dhruv-15-03 wants to merge 1 commit into
Conversation
Use the explicit truncation overload and deterministic byte assertions. Cover the strict combined statistics-size boundary while preserving null-count omission and constructor validation. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The binary-statistics truncation test calls a static default overload through a configured converter instance. The constructor's truncation length is ignored, and the existing ordering-only assertions let untruncated bounds pass.
What changes are included in this PR?
toParquetStatistics(stats, truncateLen)overload.Only
TestParquetMetadataConverter.javachanges. The personal-fork validation workflow is not included.Are these changes tested?
Yes. On the contribution commit
a9940be5cfee6962dc0f3e064b4c619a07b2d3b7(Temurin 17), the fullTestParquetMetadataConverterclass ran 78 tests with 0 failures, 0 errors and 0 skipped, includingtestBinaryStatsWithTruncationandtestBinaryStatsWithTruncationAtSizeLimit.mvn -pl parquet-hadoop spotless:checkreported 262 files clean. Run: https://github.com/dhruv-15-03/parquet-java/actions/runs/36249258685Are there any user-facing changes?
None. Production code and output semantics are unchanged. #3819 addresses null-count serialization; this PR repairs a separate test-coverage gap and does not fix or close #3574.
Closes #3820