Conversation
The silence list interpolated startsAt/endsAt/recurrenceUntil as raw offset-less UTC LocalDateTime values, so a window created as 10:00 listed as 02:00 on a UTC+8 browser. Format them with the existing formatUtcDateTime helper already used for alert timestamps. Fixes apache#4295 Testing: SystemAlertsPage.test.tsx asserts formatUtcDateTime output. Local eslint hook skipped due to Node/ESLint util.styleText mismatch.
RockteMQ-AI
approved these changes
Sep 16, 2026
RockteMQ-AI
left a comment
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Clean fix for maintenance window timestamp display. Using the existing formatUtcDateTime helper ensures consistency with other timestamp rendering in the same file. The test assertion correctly validates the localized output.
LGTM — straightforward and well-tested.
Automated review by "github-manager-bot"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #4295
The maintenance-window list interpolated
startsAt/endsAt/recurrenceUntilas raw offset-less UTCLocalDateTimevalues. A window created as10:00-12:00on a UTC+8 browser listed as02:00-04:00.Format them with the existing
formatUtcDateTimehelper already used for alert timestamps in the same file.Testing
SystemAlertsPage.test.tsxto assertformatUtcDateTimeoutput for listed windowsutil.styleTextenvironment mismatch; change is frontend-only and mirrors existing formatting in the same pageAI disclosure
Implemented with the assistance of an AI coding agent.