[ISSUE #4346] Clarify supported NameServer address formats - #4383
Open
Yanghanrui666 wants to merge 1 commit into
Open
Yanghanrui666 wants to merge 1 commit into
Yanghanrui666 wants to merge 1 commit into
Conversation
RockteMQ-AI
approved these changes
Sep 16, 2026
RockteMQ-AI
left a comment
There was a problem hiding this comment.
Summary
Good UX improvement — adds clear guidance text explaining what NameServer address formats are supported (SLB/VIP, Headless DNS, comma-separated list) and that the address must be reachable from the Studio server. Properly internationalized (zh/en) with tests covering both the guidance display and localization.
LGTM.
Automated review by "github-manager-bot"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
InfoBannerguidance to the NameServer create/edit and connection-test flows.This supersedes #4365. The previous PR became unmergeable and was closed when the
rocketmq-studiobase branch was deleted; this branch is now rebased ontomaster.Testing
npm test -- src/pages/cluster/__tests__/ClusterPage.test.tsx --pool=threads --maxWorkers=1— 27 passednpm run build— passednpm run lint— 0 errors (existing repository warnings only)Fixes #4346