Skip to content

[ISSUE #4346] Clarify supported NameServer address formats - #4383

Open
Yanghanrui666 wants to merge 1 commit into
apache:masterfrom
Yanghanrui666:feat/studio-nameserver-address-guidance
Open

Yanghanrui666 wants to merge 1 commit into
apache:masterfrom
Yanghanrui666:feat/studio-nameserver-address-guidance

Conversation

@Yanghanrui666

Copy link
Copy Markdown
Contributor

Summary

  • Add localized InfoBanner guidance to the NameServer create/edit and connection-test flows.
  • Clarify that Studio connects directly from the server, so the address must be reachable from the Studio server.
  • Document SLB/VIP, headless Service DNS, and comma-separated NameServer address examples in Chinese and English.
  • Add focused Chinese and English regression coverage.

This supersedes #4365. The previous PR became unmergeable and was closed when the rocketmq-studio base branch was deleted; this branch is now rebased onto master.

Testing

  • npm test -- src/pages/cluster/__tests__/ClusterPage.test.tsx --pool=threads --maxWorkers=1 — 27 passed
  • npm run build — passed
  • npm run lint — 0 errors (existing repository warnings only)
  • Prettier check — passed

Fixes #4346

@RockteMQ-AI RockteMQ-AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

Good UX improvement — adds clear guidance text explaining what NameServer address formats are supported (SLB/VIP, Headless DNS, comma-separated list) and that the address must be reachable from the Studio server. Properly internationalized (zh/en) with tests covering both the guidance display and localization.

LGTM.


Automated review by "github-manager-bot"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Studio][UX] Clarify supported NameServer address formats

2 participants