ZOOKEEPER-5092: sequence numbers don't increment past Integer.MAX_VALUE - #2462
Open
kalayciburak wants to merge 1 commit into
Open
kalayciburak wants to merge 1 commit into
kalayciburak wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sequential node names are a signed 32-bit parent
cversion. The programmer guide says the counter overflows past 2147483647 and the next name is<path>-2147483648.PrepRequestProcessoralready computes that wrap (MAX_VALUE + 1==Integer.MIN_VALUE) and puts it on the create txn.DataTree.createNodeandsetCversionPzxidthen drop it: the fuzzy-snapshot guard only applies a cversion that is numerically larger.Integer.MIN_VALUEis not larger thanInteger.MAX_VALUE, so the parent stays at 2147483647 and the next sequential create reuses that suffix.The wrap from
Integer.MAX_VALUEtoInteger.MIN_VALUEis now treated as a forward step. Any other smaller value is still ignored, so fuzzy replay cannot rewind the counter.This does not change the on-disk counter width. ZOOKEEPER-4706 (open, new 64-bit create modes) is a separate feature.
Test plan
mvn -pl zookeeper-server -am -Dtest=DataTreeTest#testCversionOverflowAdvances+testNoCversionRevert+testIncrementCversion -Dsurefire.failIfNoSpecifiedTests=false test(Java 17)mvn -pl zookeeper-server checkstyle:check(0 violations)Before the fix,
testCversionOverflowAdvancesfailed withexpected: <-2147483648> but was: <2147483647>.