Repository navigation
fix: reject non-positive expires_in in signed public URLs - #1182
Merged
Merged
Conversation
vdusek
added
adhoc
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1182 +/- ##
=======================================
Coverage 95.66% 95.67%
=======================================
Files 61 61
Lines 6461 6473 +12
=======================================
+ Hits 6181 6193 +12
Misses 280 280
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
October 30, 2026 07:46
apify-service-account
added
the
tested
Pijukatel
approved these changes
Nov 2, 2026
Pijukatel
left a comment
Pijukatel
left a comment
Contributor
There was a problem hiding this comment.
Maybe just mention in Args description that None means never expire
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_items_public_urlandcreate_keys_public_url(sync and async) now raiseValueErrorwhenexpires_inis zero or negative. The check runs before any request. Without it,timedelta(0)produced a URL that expired immediately and a negative value one that was already expired. The JS client rejects these values too.Relates to apify/apify-client-js#1183
✍️ Drafted by Claude Code