Repository navigation
fix!: store copies of data in MemoryStorageBackend - #2376
Merged
Merged
Conversation
vdusek
added
the
t-tooling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v2 #2376 +/- ##
=====================================
Coverage ? 94.32%
=====================================
Files ? 188
Lines ? 13849
Branches ? 0
=====================================
Hits ? 13063
Misses ? 786
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
vdusek
marked this pull request as ready for review
October 31, 2026 11:48
![apify-approval-mirror[bot]](https://avatars.githubusercontent.com/u/24586296?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MemoryStorageBackendstores a JSON snapshot of each dataset item and of each key-value store value with a JSON content type, so mutating an object afterpush_dataorset_valueno longer changes stored data. Reads return copies too. The snapshot serializes the same way asFileSystemStorageBackend(default=str), so both backends accept and reject the same values.push_datasnapshots the whole batch first, so an unserializable item stores nothing.Values with a non-JSON content type are stored as they are, matching the content-type check of the other backends.
Closes: #2313
✍️ Drafted by Claude Code