Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2383 +/- ##
==========================================
- Coverage 94.05% 94.03% -0.02%
==========================================
Files 184 184
Lines 13662 13707 +45
==========================================
+ Hits 12850 12890 +40
- Misses 812 817 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
apify-factory
left a comment
There was a problem hiding this comment.
Looks good, nothing blocking.
🏭 Factory review — ℹ️ not auto-approved
This change was reviewed but cannot be auto-approved: a gate failed, so the review cannot end in an approval.
| check | result |
|---|---|
| Static gates | ❌ 13/16 — max-files, max-lines, file-extensions |
| Review findings | ✅ none |
| Reviewer escalation | ❌ Extends public interfaces (BrowserController.get_context_headers, CrawleePage.context_headers) and changes what context.request.headers shows in hooks and handlers, along with which headers go through the navigation interceptor. |
Juror 1 — claude-sonnet-5-5, adversarial |
⏭️ skipped — a gate failed |
Why it was not auto-approved
Failed gates:
max-files: 11 changed files, limit 10max-lines: 261 changed lines (+238/-23), limit 200file-extensions: disallowed extension: docs/03_concepts/16_http_headers.mdx
The comments above are the review itself; this section only explains the approval decision. Push a change and request @apify-factory again to re-run it, or ask a human to review.
Reviewed 75f13d56f · workflow run
|
We need to double-check how TS behaves here. But at the moment I'm not sure there's a bug here.
For the browser, the headers that were actually sent are already available via |
PlaywrightCrawlerandStagehandCrawlernow show the extra headers a browser context sends (from the fingerprint or header generator) incontext.request.headers.BrowserController.get_context_headers(page)returns these headers.new_page()is unchanged, and the default implementation returns{}, so custom controllers keep working.CrawleePagegets acontext_headersfield.AcceptandSec-Fetch-*are filtered out with browserforge'sonly_injectable_headers, because Chromium sets them per request.AdaptivePlaywrightCrawlerdoes not send them.Supersedes #2284.
Closes: #1055
✍️ Drafted by Claude Code