Repository navigation
K2GO-458 fix(notifications): give each foreground service a unique notification id - #645
Merged
Merged
Conversation
…tification id Id 7 was shared by CodeAssets/Kolibri/DeepOp and InstallNotifications.MODULE_FAIL_ID, id 8 by CloneShare/Forgejo; concurrent services overwrote each other's notification. Reassign Kolibri 9, DeepOp 12, MODULE_FAIL 13, Forgejo 14 (CodeAssets 7, CloneShare 8 unchanged).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notification id 7 was shared by CodeAssetsDownloadService, KolibriSeedService, DeepOpService and InstallNotifications.MODULE_FAIL_ID; id 8 by CloneShareService and ForgejoSeedService. Concurrent services overwrote each other’s foreground notification (and stopping one could drop another’s).
Reassigns to unique ids: KolibriSeedService 9, DeepOpService 12, ForgejoSeedService 14, InstallNotifications.MODULE_FAIL_ID 13 (explicit, replacing ONGOING_ID + 4 which resolved to 7). CodeAssetsDownloadService (7) and CloneShareService (8) keep theirs; low-range ids are now unique (2..14).
Verification: compileStandardDebugJavaWithJavac green; no code references the old ids by literal (all notify/cancel go through the per-service constant).