Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added the translate button #1591

Closed
wants to merge 4 commits into from

Conversation

CodeMosaic7
Copy link

@CodeMosaic7 CodeMosaic7 commented Oct 29, 2024

Title and Issue number

fix: "Select Language" Dropdown Misplacement and Poor Accessibility

Issue No. : #1437

Code Stack :

Close #1437

Description

Replaced the google translate widget with a button which on hovering will open widget to translate the website.

Video/Screenshots (mandatory)

image
On hovering
image
Choosing the language
image

Type of PR

  • [ X] Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Checklist:

  • [X ] I have performed a self-review of my code.
  • [X ] I have commented my code, particularly in hard-to-understand areas.
  • [X ] I have tested the changes thoroughly before submitting this pull request.
  • [X ] I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • [ X] I have gone through the contributing.md file before contributing
  • [X ] I have Starred the Repository.

Additional context:

##Are you contributing under any Open-source programme?

  • [X ] I am contributing under GSSOC'24 Extended
  • I am contributing under Hacktoberfest'24

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

netlify bot commented Oct 29, 2024

Deploy Preview for taupe-cendol-f7e2bb ready!

Name Link
🔨 Latest commit 6b48eee
🔍 Latest deploy log https://app.netlify.com/sites/taupe-cendol-f7e2bb/deploys/67224be268f2c00008681d25
😎 Deploy Preview https://deploy-preview-1591--taupe-cendol-f7e2bb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@CodeMosaic7 CodeMosaic7 changed the title Added the translate button fix: Added the translate button Oct 29, 2024
Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeMosaic7 this pr has merge conflicts , please try to resolve this

@apu52 apu52 added the help wanted Extra attention is needed label Oct 30, 2024
@CodeMosaic7
Copy link
Author

@CodeMosaic7 this pr has merge conflicts , please try to resolve this

Resolved the conflicts.

Copy link
Owner

@apu52 apu52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@CodeMosaic7

image

the total project messed up after your commit
Please try to do one thing , close this pr for now , try to make a new branch on your forked pr , then try to push all of your changes there & then make a new pr

@CodeMosaic7 CodeMosaic7 closed this Nov 1, 2024
@CodeMosaic7 CodeMosaic7 deleted the tranlate-button branch November 1, 2024 16:30
@CodeMosaic7
Copy link
Author

I'll try to figure out why that is happening and will generate a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "Select Language" Dropdown Misplacement and Poor Accessibility
2 participants