feat: Updated ui in topdeals.html #1599
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changed the background and the alignment of card contents
|
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
✅ Deploy Preview for taupe-cendol-f7e2bb ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
apu52
requested changes
Oct 31, 2024
| @@ -14,7 +14,7 @@ | |||
|
|
|||
| body { | |||
| font-family: Arial, sans-serif; | |||
| background:url("bestdeals.jpg"); | |||
| background:url("topdeals_bg.jpg"); | |||
There was a problem hiding this comment.
u have added some bg , but there is only a white bg its showing that , & there is alo an unusual blank space on the top of the page
apu52
added
wontfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changedthe background and the alignment of card contentsTitle and Issue number
Title : UI can be improved
Issue No. : 1412
Code Stack : html, css
Close #1412
Description
changed the background of the top deals page and changed the alignment of card content.
Video/Screenshots (mandatory)
Type of PR
Checklist:
contributing.mdfile before contributingAdditional context:
##Are you contributing under any Open-source programme?
GSSOC'24 Extended