Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update goto.adoc #767

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update goto.adoc #767

wants to merge 1 commit into from

Conversation

jackaroo-DE
Copy link

It should be considered that - as opposed to functions - a "goto"-code can never return to its calling point. So instead of using the "goto"-control, it is advisable to "break" or "continue" the nested structures and define and call a function instead.

It should be considered that - as opposed to functions - a "goto"-code can never return to its calling point. So instead of using the "goto"-control, it is advisable to "break" or "continue" the nested structures and define and call a function instead.
Copy link
Collaborator

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the decision on whether this sort of change is desirable is contingent on #623.

If the Arduino Language Reference is intended to document the Arduino core API and give a brief overview of the common parts of C++, such as goto, pointing users to use external C++ references for details on the aspects of the Arduino Language that are inherited from C++, then I would say that this proposed change is not beneficial.

On the other hand, if we are going to taking the approach that the Arduino Language Reference is the sole source of documentation for the Arduino Language, then it would be beneficial to provide more comprehensive documentation of the parts inherited from C++, though I would like to find a way to separate the more detailed information to avoid making the Arduino Language Reference less contributor friendly.

So my opinion is this PR should be put on hold until there is an official decision on #623.

@per1234 per1234 added the on hold The PR should not be merged at this time label Aug 19, 2020
@CLAassistant
Copy link

CLAassistant commented Apr 9, 2021

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement on hold The PR should not be merged at this time
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants